Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing paper for submission #7

Closed
wants to merge 1 commit into from
Closed

Fixing paper for submission #7

wants to merge 1 commit into from

Conversation

arfon
Copy link

@arfon arfon commented May 26, 2017

👋 @kortschak, I had to make these small changes when accepting your JOSS paper.

@kortschak
Copy link
Member

kortschak commented May 26, 2017 via email

Copy link
Member

@kortschak kortschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arfon, sorry. I was looking at whether the referencing labels show up in the text (Biopython call themselves Biopython and not BioPython FWIW) and noticed that the referencing is broken by et al. truncation.

In text snippet:

Similarly, Biopython (al 2009) provides...

References:

al, Cock P.J.A. et. 2009. “Biopython: Freely Available Python Tools for Computational Molecular Biology and Bioinformatics.” Bioinformatics 25 (11): 1422–3. doi:10.1093/bioinformatics/btp163.

al, Stajich J.E. et. 2002. “The Bioperl Toolkit: Perl Modules for the Life Sciences.” Genome Research 12 (10): 1611–8. doi:10.1101/gr.361602.

I am happy to make the required changes in another PR. Does JOSS just use pandoc for this so I can check?

@@ -55,7 +55,7 @@ @Article{BioPerl
}

@Article{BioPython,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/BioPython/Biopython/g

Packages within bíogo/ncbi provide Go application programmer interfaces to the NCBI BLAST and EUtilities services.
The design of bíogo/ncbi is light weight, allowing the user to make use of the Go language's control structures and data types, rather than imposing a library-specific access approach.
In addition to allowing remote BLAST searches, BioPerl and Biopython provide mechanisms to parse XML output from local BLAST search via BioPerl's Bio::SearchIO and Biopythons Bio.Blast NCBIXML
In addition to allowing remote BLAST searches, BioPerl and Biopython provide mechanisms to parse XML output from local BLAST search via BioPerl's Bio::SearchIO and Biopythons Bio.Blast NCBIXML
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/$/. /

@arfon
Copy link
Author

arfon commented May 26, 2017

Yeah we just use pandoc with citeproc for the bibtex.

BTW I made the change to the author list in the bibtex as pandoc can't parse author lists with commas - instead I think it needs to be 'Smith A.M. and Jones A. and... etc'

@kortschak
Copy link
Member

I'm fiddling at the moment. Will send a PR and /cc you.

@kortschak
Copy link
Member

Closing in favour of #8.

@kortschak kortschak closed this May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants