Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write the run_id to staged log #59

Closed
jmetz opened this issue Apr 29, 2024 · 8 comments · Fixed by #60
Closed

Write the run_id to staged log #59

jmetz opened this issue Apr 29, 2024 · 8 comments · Fixed by #60
Assignees
Labels
enhancement New feature or request

Comments

@jmetz
Copy link
Contributor

jmetz commented Apr 29, 2024

In the workflow of the collection CI, write the run_id (https://docs.github.com/en/actions/learn-github-actions/variables) to staged log, then get it from the client, so we can display it to the reviewer for the CI status

Relates to bioimage-io/bioimageio-uploader#77

which is part of

bioimage-io/bioimageio-uploader#65

@jmetz jmetz added the enhancement New feature or request label Apr 29, 2024
@FynnBe
Copy link
Member

FynnBe commented Apr 29, 2024

the run_id is part of the status as (run_url) , which is saved to versions.json, see https://bioimage-io.github.io/collection/bioimageio_collection_backoffice/db_structure/versions.html#_StatusBase.run_url

should I log them in addition?

@jmetz jmetz changed the title In the workflow of the collection CI, write the run_id (https://docs.github.com/en/actions/learn-github-actions/variables) to staged log, then get it from the client, so we can display it to the reviewer for the CI status Write the run_id to staged log Apr 29, 2024
@jmetz
Copy link
Contributor Author

jmetz commented Apr 29, 2024

Think the url is enough - thats great thanks.

Does it save multiple run_urls per version or just the latest? In principle multiple runs could happen on the same version, right?

@FynnBe
Copy link
Member

FynnBe commented Apr 29, 2024

one per version (so if a test is running the run_url of the staging process will no longer be available, because it is now pointing to the test run)

@jmetz
Copy link
Contributor Author

jmetz commented Apr 29, 2024

Hmm should we save them all? Might be better - and the last entry will always be the latest run.

@FynnBe
Copy link
Member

FynnBe commented Apr 29, 2024

then I would add them to the log where we can keep this kind of history. (I don't want to clutter versions.json with status history)

@FynnBe
Copy link
Member

FynnBe commented Apr 29, 2024

ok @jmetz ?

@jmetz
Copy link
Contributor Author

jmetz commented Apr 29, 2024

Ah I see, yep, that sounds good. So new log context things - so we can even tell which ones are test logs etc, right?

@jmetz
Copy link
Contributor Author

jmetz commented Apr 29, 2024

I saw you already have "bioimageio-core" and "..spec" contexts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants