Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parametrize the operator that joins cell QC filters (| or &) #7

Merged
merged 4 commits into from
Dec 18, 2023
Merged

parametrize the operator that joins cell QC filters (| or &) #7

merged 4 commits into from
Dec 18, 2023

Conversation

gorgitko
Copy link
Contributor

@gorgitko gorgitko commented Dec 4, 2023

This allows users to choose between AND or OR operator for joining cell QC filters.

@gorgitko gorgitko force-pushed the feature/customizable-operator-for-cell-qc-filters branch from 96e0672 to 90f4843 Compare December 4, 2023 18:10
vucinick
vucinick requested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@vucinick vucinick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have quickly looked through the code. It looks good. Just add the possibility that the operator has values OR and AND as it is mentioned in the vignette. Or change the vignette :)

R/single_sample_input_qc.R Show resolved Hide resolved
@vucinick vucinick merged commit 9bdf431 into main Dec 18, 2023
1 check passed
@vucinick vucinick deleted the feature/customizable-operator-for-cell-qc-filters branch December 18, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vucinick vucinick vucinick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gorgitko @vucinick