feat: inference_fn changed from asynchronous to synchronous #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix bugs - complete function test - delete the directory parameter in TaskConfig Resove #1
bioinformatist
requested changes
Jul 22, 2023
bioinformatist
requested changes
Jul 22, 2023
bioinformatist
requested changes
Jul 25, 2023
cml-tdengine/src/core/inference.rs
Outdated
| @@ -149,6 +163,146 @@ mod tests { | |||
|
|
|||
| #[tokio::test(flavor = "multi_thread")] | |||
| async fn test_concurrent_inference() -> Result<()> { | |||
| let cml = TDengine::from_dsn("taos://"); | |||
| let taos = cml.build_sync()?; | |||
There was a problem hiding this comment.
Why connection by blocking here?
cml-tdengine/src/core/inference.rs
Outdated
Comment on lines
280
to
294
| tokio::spawn({ | ||
| async move { | ||
| cml.inference( | ||
| batch_meta_1, | ||
| Field::new("output", Ty::Float, 8), | ||
| available_status, | ||
| &mut batch_data_1, | ||
| &pool, | ||
| inference_fn, | ||
| ) | ||
| .await | ||
| .unwrap(); | ||
| } | ||
| }) | ||
| .await?; |
There was a problem hiding this comment.
We may need more than one batch running simultaneously to validate if async works well.
correct inference test_concurrent_inference
bioinformatist
requested changes
Jul 25, 2023
cml-tdengine/src/core/inference.rs
Outdated
Comment on lines
305
to
327
| let inference_data_fn = |inference_data, inference_model| { | ||
| if inference_data + inference_model > 25.0 { | ||
| Some(Value::Float(inference_data + model_inference)) | ||
| } else { | ||
| None | ||
| } | ||
| }; | ||
| for inference_data in vec_data.iter() { | ||
| let output = inference_data_fn( | ||
| fs::read_to_string(inference_data.data_path()) | ||
| .unwrap() | ||
| .parse::<f32>() | ||
| .unwrap(), | ||
| model_inference, | ||
| ); | ||
| result.push( | ||
| NewSampleBuilder::default() | ||
| .data_path(inference_data.data_path().to_path_buf()) | ||
| .output(output) | ||
| .build() | ||
| .unwrap(), | ||
| ); | ||
| } |
There was a problem hiding this comment.
There's no need for use a closure here, for the closure won't be used more than one time. Just move the calculations into loop, and use variables for staging intermediate results if necessary.
bioinformatist
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resove #1