Fix #917: Symmetry doesn't display with non-US locales #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always use the US locale when printing jmol scripts - Update Jmol to 14.31.10 while we're at it.
This runs QuatSymmetryDetector. It would be better to mock the results, but this is nontrivial with the current implementation.
These seem to be regularly deleted by IDEs running on different JDKs. If you see a warning, please find the correct syntax to silence it rather than deleting the cast.
heuermh
approved these changes
Mar 1, 2021
sbliven
added a commit
to sbliven/biojava-sbliven
that referenced
this pull request
Jul 31, 2021
biojava#918 showed that locales which use commas for floating-point numbers can cause problems with output formats. This commit fixes a number of other cases. - Force Locale.US when outputting floats to files/streams - Usually don't force Locale.US when outputting floats to standard out & logging (would lead to more consistent logs but breaks localization) - Replace some `println(String.format(` calls with Java 5 `printf`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core of this is the locale fix, which is necessary for CESymm/QuatSymm to function properly on non-US systems.
I've also included some commits for general cleanup and tests. If any of these are controversial I can revert them or move them to separate PRs.