Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error noreturn #137

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Error noreturn #137

merged 1 commit into from
Jul 6, 2024

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Jun 22, 2024

No description provided.

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.93%. Comparing base (aa7cf86) to head (f739367).

Files Patch % Lines
src/c4/error.cpp 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   96.96%   96.93%   -0.04%     
==========================================
  Files          28       28              
  Lines        3133     3130       -3     
==========================================
- Hits         3038     3034       -4     
- Misses         95       96       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/c4/ext/fast_float_all.h Dismissed Show dismissed Hide dismissed
@biojppm biojppm force-pushed the error_noreturn branch 6 times, most recently from f901f59 to 1262e68 Compare June 26, 2024 18:01
@biojppm biojppm force-pushed the error_noreturn branch 2 times, most recently from e90c340 to d0b2d40 Compare July 3, 2024 19:51
@biojppm
Copy link
Owner Author

biojppm commented Jul 6, 2024

The failing tests are fixed in #138 . Merging now.

@biojppm biojppm merged commit edd2649 into master Jul 6, 2024
264 of 274 checks passed
@biojppm biojppm deleted the error_noreturn branch July 6, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant