Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing of plain (unquoted) scalars #61

Merged
merged 14 commits into from
May 11, 2020
Merged

Improve parsing of plain (unquoted) scalars #61

merged 14 commits into from
May 11, 2020

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented May 4, 2020

Fixes #60

@coveralls
Copy link

coveralls commented May 5, 2020

Pull Request Test Coverage Report for Build 457

  • 162 of 175 (92.57%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 92.737%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/c4/yml/common.hpp 8 10 80.0%
src/c4/yml/common.cpp 13 17 76.47%
src/c4/yml/parse.cpp 140 147 95.24%
Files with Coverage Reduction New Missed Lines %
src/c4/yml/common.cpp 1 83.67%
src/c4/yml/common.hpp 1 89.19%
src/c4/yml/parse.cpp 5 89.76%
Totals Coverage Status
Change from base Build 449: 0.1%
Covered Lines: 3422
Relevant Lines: 3690

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #61 into master will increase coverage by 0.15%.
The diff coverage is 93.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   93.13%   93.28%   +0.15%     
==========================================
  Files          58       58              
  Lines        5548     5676     +128     
==========================================
+ Hits         5167     5295     +128     
  Misses        381      381              
Impacted Files Coverage Δ
test/double_quoted.cpp 100.00% <ø> (ø)
test/plain_scalar.cpp 100.00% <ø> (ø)
test/simple_doc.cpp 100.00% <ø> (ø)
test/single_quoted.cpp 100.00% <ø> (ø)
src/c4/yml/common.cpp 81.39% <75.00%> (+9.96%) ⬆️
src/c4/yml/common.hpp 88.57% <80.00%> (+1.90%) ⬆️
src/c4/yml/parse.cpp 89.50% <95.20%> (+0.36%) ⬆️
test/test_case.cpp 76.14% <96.29%> (+1.22%) ⬆️
src/c4/yml/parse.hpp 100.00% <100.00%> (ø)
test/github_issues.cpp 97.24% <100.00%> (+0.99%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592ccca...9a4cf14. Read the comment docs.

@biojppm biojppm merged commit 8ebf41d into master May 11, 2020
@biojppm biojppm deleted the issue60 branch May 11, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to parse plain flow (unquoted) scalars
2 participants