-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Widgets update #12
Conversation
data = Input("Data", Table) | ||
|
||
class Outputs: | ||
data = Output("Matching data", Table) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matching Data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
3a1ebd8
to
d9ca47a
Compare
data = Input("Data", Table) | ||
|
||
class Outputs: | ||
matching_data = Output("Matching data", Table) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant the labels. We title case them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
d9ca47a
to
f7aa835
Compare
Thank you for this! I have some extra requests, if possible.
|
@ajdapretnar : Ok, but I will open a new PR. |
Number 2 belongs here I think (error solving). The rest can go into a separate PR. |
Agree bullets above are out of scope. |
Except that QVariant wasn't solved, but who cares... |
Warning is not an error nor necessarily a bug. If the warning in question is:
I'm happy to take it in a new PR as it might not be as trivial as this was. |
I agree, it is not trivial. |
Fixes #11.
+
.gitignore
+github templates