[ENH] OWRank: Widget improvements #1560
Conversation
Current coverage is 88.66% (diff: 100%)@@ master #1560 diff @@
==========================================
Files 78 78
Lines 8111 8111
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7192 7192
Misses 919 919
Partials 0 0
|
VesnaT
force-pushed
the
rank
branch
2 times, most recently
from
ff1a294
to
5f76e67
Compare
|
I like this very much. Not sure if this is a part of this PR or not, but there's an issue with Report. When reporting on all possible scoring methods for discrete class, the last few columns fall out of view. When saving to .pdf, columns names are shifted. Could probably be fixed in another PR I reckon. |
|
Important note: load housing.tab and connect it to Rank. Then connect PCA to Rank and Logistic Regression (it is wrong, I know). The widget crashes. Before it it displayed only the error message. Please check. |
VesnaT
force-pushed
the
rank
branch
2 times, most recently
from
9522f22
to
42d4e56
Compare
|
Rebase, please. While you're at it, can you also handle the case in which the data has no class, but it has an outside scorer (e.g. PCA). See issue #1556. As shown in PR #1566, it suffices to remove the error message and setting the data to None - except not in that you mustn't do it in |
VesnaT
force-pushed
the
rank
branch
2 times, most recently
from
afff0b4
to
950d87e
Compare
Will be fixed in 71b62c8 |
|
Sorry, all good. |
Scores are computed only when checked and when deselected stored in cache for later use. Attribute selection is context dependent and progress bar is added to the widget to show percentage of computed scores.
|
You can wait but you don't have to. It can be fixed in another PR. |
Enable selection of scoring method. Scores are computed only when checked and when deselected stored in cache for later use.
Attribute selection is context dependent and progress bar is added to the widget to show percentage of computed scores.
Fixes #1547 and #1556