[FIX] preprocess: Fix RemoveNaNClasses / Use existing HasClass #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2450 +/- ##
========================================
+ Coverage 73.9% 74.3% +0.4%
========================================
Files 321 321
Lines 55993 56021 +28
========================================
+ Hits 41379 41627 +248
+ Misses 14614 14394 -220 |
lanzagar
force-pushed
the
removenancls
branch
3 times, most recently
from
4c294fa
to
4444e49
Compare
lanzagar
changed the title
lanzagar
commented
Jul 10, 2017
| @@ -197,6 +198,7 @@ def __call__(self, data): | |||
| return data.transform(domain) | |||
|
|
|||
|
|
|||
| @deprecated("Orange.data.filter.HasClas") | |||
There was a problem hiding this comment.
HasClas -> HasClass
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
SklLearner methods do not work on SqlTable data because of the RemoveNaNClasses preprocessor.
Description of changes
Use an existing (more general) implementation of the RemoveNaNClasses preprocessor - the HasClass filter.
Why do we even have both (functionality looks exactly the same)?
Before merging, we should check whether the RemoveNaNClasses preprocessor can be removed completely and HasClass filter used in its place.
Includes