OWDataSets: refactor code, move some functionalities to new methods #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanzagar
reviewed
Mar 8, 2018
Orange/widgets/data/owdatasets.py
Outdated
| self._header_labels = [header['label'] for _, header in self.HEADER_SCHEMA] | ||
| self._html_description_tags = ['year', 'source', 'title', 'description', 'seealso', 'references'] | ||
|
|
||
| self._header_index = namedtuple('_header_index', [*[info_tag for info_tag, _ in self.HEADER_SCHEMA]]) |
There was a problem hiding this comment.
This is a syntax error on older python versions (as reported by failing tests).
But also, I don't see a reason for unpacking and repacking the list...
There was a problem hiding this comment.
Thanks, forgot to remove this when I was testing something.
lanzagar
reviewed
Mar 8, 2018
Orange/widgets/data/owdatasets.py
Outdated
|
|
||
| # add missing variables to the namespace | ||
| # not needed if all info files have the same JSON structure | ||
| for tag in self._html_description_tags: |
There was a problem hiding this comment.
Not all variables are in _html_description_tags, e.g. one test fails, because 'size' is missing (which is in _header_index, but not in _html_description_tags.
Also, did you make sure that it is OK to set all missing things to None? Previously, some default values were different, e.g. [] for 'references'.
JakaKokosar
force-pushed
the
master
branch
3 times, most recently
from
8ad5494
to
4fd7627
Compare
Codecov Report
@@ Coverage Diff @@
## master #2950 +/- ##
==========================================
+ Coverage 81.86% 81.86% +<.01%
==========================================
Files 329 329
Lines 56770 56782 +12
==========================================
+ Hits 46474 46486 +12
Misses 10296 10296 |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
biolab/orange3-single-cell#121
Description of changes
Split large chunk of code into smaller methods, so we can easily override them.
Moved item model creation in a separate method.
Includes