-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Various fixes of box plot #4231
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4231 +/- ##
==========================================
+ Coverage 85.95% 85.95% +<.01%
==========================================
Files 394 394
Lines 70174 70183 +9
==========================================
+ Hits 60319 60328 +9
Misses 9855 9855 |
69edf27
to
3143948
Compare
np.array | ||
Array with concatenated unknowns as a row and column | ||
""" | ||
return np.append(np.array(self), self.unknowns) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for append says it already works on the copy of the first arg - do you really need to make another copy? (or are you doing this to change it from a distribution to an array?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just to transform to array from distribution. Otherwise, it stays distribution which is not good since we get another distribution with unknown attributes. In this case, the unknowns attribute is joined together with other data so it needs to be an array.
3143948
to
c08b9d1
Compare
When stretch bars is disabled, and there are missing values in the subgroup with the largest bar, the size of that subgroup (written to the right of the bar) falls out of view. |
c08b9d1
to
7f79121
Compare
@lanzagar it should be fixed now. |
Issue
While working on some data I found few bugs in the Box Plot widget. Some issues were produced by #4135 some are old.
Description of changes
All of the above errors fixed and added tests
Important before you test run
pip install -e .
in Orange directory since Cython code was changed and C code needs to be compiled.Includes