Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Lazy signals for Hierarchical Clustering #6348

Merged
merged 4 commits into from
Aug 21, 2023
Merged

[ENH] Lazy signals for Hierarchical Clustering #6348

merged 4 commits into from
Aug 21, 2023

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Feb 24, 2023 •
edited
Loading

Issue

Ref. #5720.

Includes
  • Code changes
  • Tests

@janezd janezd mentioned this pull request Feb 24, 2023
Merged
@janezd janezd changed the title Lazy signals for Table and Hierarchical Clustering Lazy signals for Hierarchical Clustering Mar 31, 2023
@markotoplak
Copy link
Member

@janezd, could you rebase this? Also, biolab/orange-widget-base/pull/238 was released in widget-base 4.21.0, so if we change requirements, this PR can be merged.

@janezd janezd marked this pull request as ready for review August 18, 2023 20:50
@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

Merging #6348 (3f4df37) into master (1725baa) will increase coverage by 0.00%.
The diff coverage is 95.65%.

❗ Current head 3f4df37 differs from pull request most recent head 2fc2717. Consider uploading reports for the commit 2fc2717 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6348   +/-   ##
=======================================
  Coverage   87.68%   87.69%           
=======================================
  Files         321      321           
  Lines       69406    69429   +23     
=======================================
+ Hits        60859    60885   +26     
+ Misses       8547     8544    -3

@janezd janezd mentioned this pull request Aug 20, 2023
Merged
3 tasks
@markotoplak markotoplak self-assigned this Aug 21, 2023
@markotoplak markotoplak changed the title Lazy signals for Hierarchical Clustering [ENH] Lazy signals for Hierarchical Clustering Aug 21, 2023
markotoplak
markotoplak reviewed Aug 21, 2023
View reviewed changes
Orange/widgets/utils/state_summary.py
@@ -129,11 +131,11 @@ def b(s):

def missing_values(value):
if value:
return f'({value*100:.1f}% missing values)'
return f' ({value*100:.1f}% missing values)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume no one calls this externally, and moving a space inside won't be a problem. But I am curious why did you do so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of space-nazism. We had f'Features: {features} {features_missing}' where features_missing could be an empty string, resulting in a space at the end of the line. I wouldn't be able to sleep knowing that.

@markotoplak markotoplak merged commit eb3633c into biolab:master Aug 21, 2023
23 of 44 checks passed
@PrimozGodec PrimozGodec mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markotoplak markotoplak markotoplak left review comments

Assignees

@markotoplak markotoplak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janezd @markotoplak