Clean up SklImpute #6508
Merged
Clean up SklImpute #6508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
clean-sklimpute
branch
from
281818d
to
703fe5e
Compare
markotoplak
force-pushed
the
clean-sklimpute
branch
from
703fe5e
to
1d076ee
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6508 +/- ##
==========================================
- Coverage 87.66% 87.66% -0.01%
==========================================
Files 321 321
Lines 69374 69371 -3
==========================================
- Hits 60817 60814 -3
Misses 8557 8557 |
markotoplak
added
the
dask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
SklImpute did not have tests.
Also, in 2017 it was modified to use domain transformation. After that, it effectively did the transformation twice: through the domain conversion and through scikit's
fit_transform.We originally wrote this through
fit_transformfor speed, but it seems we did not miss it much since 2017.Description of changes
This PR simplifies the current code and makes it just a tiny bit faster.
This set of commits is mostly cherry-picked from the markotoplak/orange3/dask-subarray branch.
Includes