Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate edge ids? #21

Closed
cmungall opened this issue Apr 28, 2018 · 3 comments
Closed

generate edge ids? #21

cmungall opened this issue Apr 28, 2018 · 3 comments

Comments

@cmungall
Copy link
Contributor

Some KGs will provide edge IDs, others won't should we always provide one, eg, by hashing? hashing the SPO will not work as we allow separate SPOs with different semantics

@deepakunni3
Copy link
Member

Would it make sense to just generate a UUID for every edge added into the networkx MultiDiGraph?

I did play around with assigning unique edge IDs, when not available, in NeoTransformer. Not sure if there is more to the specification.

@deepakunni3
Copy link
Member

Currently KGX has edge IDs via a key of subject-predicate-object. Of course this is less than ideal.

The most accommodating would be to have a UUID for each edge. The disadvantage here is that there will be no merging of edges since each edge is treated as unique. Perhaps this is not a problem at all.

@deepakunni3
Copy link
Member

IDs for edges can be seen as serving two purposes:

  • uniquely locating an edge
  • merging edges between graphs

We now generate UUIDs for edges. Addressed as part of #214

But we still merge edges based on a criteria of SPO. This criteria can be made configurable in future iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants