Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtered evidence file #66

Merged
merged 6 commits into from
Jul 11, 2017
Merged

Filtered evidence file #66

merged 6 commits into from
Jul 11, 2017

Conversation

dougli1sqrd
Copy link
Contributor

No description provided.

@dougli1sqrd dougli1sqrd requested a review from cmungall July 7, 2017 04:25
@dougli1sqrd
Copy link
Contributor Author

Still testing, but seems to run on goa_chicken_complex-src.gaf with --filter-out IEA correctly, moving the non IEA lines to a different specified file, also while maintaining the full parsed version.

cmungall
cmungall approved these changes Jul 7, 2017
View reviewed changes
Copy link
Contributor

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the eventual goal is to rename 'gafparser' to generic 'assocparser', and rename 'gaf' to 'gafparser'

(very minor point: let's try and make separate PRs for refactors and new functionality in future)

Assume this is tested for gpads too?

@dougli1sqrd dougli1sqrd merged commit a550bfd into biolink:master Jul 11, 2017
@dougli1sqrd dougli1sqrd mentioned this pull request Jul 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougli1sqrd @cmungall