Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KineticInfo of state_transition rule not working as intended #189

Closed
formersbach opened this issue Aug 31, 2022 · 0 comments · Fixed by #190
Closed

KineticInfo of state_transition rule not working as intended #189

formersbach opened this issue Aug 31, 2022 · 0 comments · Fixed by #190
Assignees
Labels
bug Something isn't working text2model Text-to-model conversion

Comments

@formersbach
Copy link
Contributor

Description:

Rate of Kinetic Info is supposed to contain the pure rate equation with just parameters and species. state_transition method wrongly adds concentration identifiers such as y[species].

Reproduce:

Text file containing:

A --> B

Convert to model:

from biomass import Text2Model, create_model
model = Text2Model("test.txt")
model.convert(overwrite=True)
print(model.kinetics)

Expected:

model.kinetics.rate : kf1 * A

Observed:

model.kinetics.rate : kf1 * y[V.A]

@formersbach formersbach added the bug Something isn't working label Aug 31, 2022
@formersbach formersbach self-assigned this Aug 31, 2022
@formersbach formersbach added the text2model Text-to-model conversion label Aug 31, 2022
formersbach added a commit that referenced this issue Aug 31, 2022
@formersbach formersbach linked a pull request Aug 31, 2022 that will close this issue
himoto pushed a commit that referenced this issue Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working text2model Text-to-model conversion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant