Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 noConfusingVoidType false positives #1383

Closed
1 task done
kamiyo opened this issue Dec 31, 2023 · 0 comments · Fixed by #1426
Closed
1 task done

💅 noConfusingVoidType false positives #1383

kamiyo opened this issue Dec 31, 2023 · 0 comments · Fixed by #1426
Assignees
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@kamiyo
Copy link

kamiyo commented Dec 31, 2023

Environment information

CLI:
  Version:                      1.4.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           "v20.9.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/4.0.2"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Rule name

noConfusingVoidType

Playground link

https://biomejs.dev/playground/?code=ZQB4AHAAbwByAHQAIABjAG8AbgBzAHQAIABhAGQAZABUAG8AQwBhAHIAdABBAGMAdABpAG8AbgAgAD0AIABjAHIAZQBhAHQAZQBBAHMAeQBuAGMAVABoAHUAbgBrADwAdgBvAGkAZAAsACAAcwB0AHIAaQBuAGcALAAgAFQAaAB1AG4AawBBAFAASQBUAHkAcABlAD4AKAAKACAAIAAgACAAJwBjAGEAcgB0AC8AYQBkAGQASQB0AGUAbQBXAGkAdABoAEMAaABlAGMAawAnACwACgAgACAAIAAgACgAcwBrAHUASQBkACwAIAB0AGgAdQBuAGsAQQBQAEkAKQAgAD0APgAgAHsACgAgACAAIAAgACAAIAAgACAAdABoAHUAbgBrAEEAUABJAC4AZABpAHMAcABhAHQAYwBoACgAYQBkAGQASQB0AGUAbQBUAG8AQwBhAHIAdAAoAHMAawB1AEkAZAApACkAOwAKACAAIAAgACAAfQAsAAoAIAAgACAAIAB7AAoAIAAgACAAIAAgACAAIAAgAGMAbwBuAGQAaQB0AGkAbwBuADoAIAAoAF8ALAAgAHsAIABnAGUAdABTAHQAYQB0AGUAIAB9ACkAIAA9AD4AIAB7AAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAcgBlAHQAdQByAG4AIAAhAGcAZQB0AFMAdABhAHQAZQAoACkALgBjAGEAcgB0AC4AaQBzAEMAaABlAGMAawBpAG4AZwBPAHUAdAA7AAoAIAAgACAAIAAgACAAIAAgAH0ALAAKACAAIAAgACAAfQAsAAoAKQA7AA%3D%3D

Expected result

The void in this case is the return type of the payload creator function in createAsyncThunk (the second property in the object). Unless I'm mistaken, the use of void is proper (and necessary for the types to work).

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico ematipico added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug labels Dec 31, 2023
@Conaclos Conaclos self-assigned this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants