📎 CSS parser parses sequence of custom idents for @font-feature-values

[unvalley]

Description

We need to extend the current implementation to support a sequence of custom idents.
For example:

@font-feature-values Otaru Kisa Times New Roman {
  @annotation { circled: 1; black-boxed: 3; }
}

@font-feature-values Otaru Kisa {
    @annotation { circled: 1; black-boxed: 3; }
}

@font-feature-values Taisho Gothic {
    @annotation { boxed: 1; circled: 4; }
}

@font-feature-values Taisho Gothic, Bar {
    @annotation { boxed: 1; circled: 4; }
}

We have in our css ungram:

AnyCssFontFamilyName =
	CssCustomIdentifier
	| CssString

We need to implement a list of CssCustomIdentifier to support the syntax.

[denbezrukov]

@kubijo could you please make a comment here?

[kubijo]

I could, but I don't think I'm the one you wanted to mention

[denbezrukov]

@kubijo I'm sorry))) I've copied a wrong tag))

[bjoroen]

I can make a comment here 😁

[bjoroen]

@denbezrukov @unvalley I'm struggling a little bit figuring out what the correct way of implementing the syntax would be.

Something like this?

CssFontFeatureValuesAtRule =
	'font-feature-values'
	items: CssCustomIdentifierList
	block: AnyCssFontFeatureValuesBlock

CssCustomIdentifierList = CssCustomIdentifier*

Or would it be something like

CssFontFeatureValuesAtRule =
	'font-feature-values'
	items: AnyCssFontFamilyName
	block: AnyCssFontFeatureValuesBlock


AnyCssFontFamilyName =
	CssCustomIdentifierList
	| CssCustomIdentifier
	| CssString

Or am I completely off? Any nudge in the correct direction would be greatly appreciated.

[denbezrukov]

I believe we need to go with:

CssFontFeatureValuesAtRule =
	'font-feature-values'
	name: AnyCssFontFamilyName
	block: AnyCssFontFeatureValuesBlock


AnyCssFontFamilyName =
	CssCustomIdentifierList
	| CssString

[bjoroen]

Thanks for the feedback, that helps a lot.

[bjoroen]

@denbezrukov

I have tried to fix this issue, but have not been able to get to a working solution.

If anyone wants to take this issue it would be ok with me, I don't think Ill manage to find a working solution.