🐛 When using React hook prefix, exhaustive deps breaks

[crutchcorn]

Environment information

↳  pnpm biome rage
CLI:
  Version:                      1.3.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           "v18.16.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.9.2"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

While the following works as-expected:

import {useState, useEffect} from "react";

const Comp = () => {
  const [count, setCount] = useState(0)

  useEffect(() => {
    setCount(v => v+1);
  }, [])
  
  return null;
}

Aliasing React like so:

import * as React from "react";

const Comp = () => {
  const [count, setCount] = React.useState(0)

  React.useEffect(() => {
    setCount(v => v+1);
  }, [])
  
  return null;
}

Forces the following error to be thrown:

This hook do not specify all of its dependencies.

Playground link

Expected result

No errors to be thrown in the code sample listed above

Code of Conduct

• I agree to follow Biome's Code of Conduct

[ematipico]

Can you provide an example with the Eslint rule, please? This rule should follow what the original rule does.

[crutchcorn]

Sure @ematipico, here you are:

https://stackblitz.com/edit/node-hcjbcn?file=src%2Findex.js,.eslintrc.js

This has ESLint setup and allows you to run npm run lint in the terminal to verify the ESLint functionality