Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Implement lint/noThisInStatic - mysticatea/no-this-in-static #59

Closed
Conaclos opened this issue Aug 23, 2023 · 4 comments · Fixed by #366
Closed

📎 Implement lint/noThisInStatic - mysticatea/no-this-in-static #59

Conaclos opened this issue Aug 23, 2023 · 4 comments · Fixed by #366
Assignees
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@Conaclos
Copy link
Member

Conaclos commented Aug 23, 2023

Description

Implement @mysticatea/no-this-in-static.

Want to contribute? Lets we know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

@Conaclos Conaclos added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages good first issue Good for newcomers labels Aug 23, 2023
@ditorodev
Copy link
Contributor

ditorodev commented Aug 30, 2023

I'm gonna try and take a hit on this! Lets see how it goes

@Conaclos Conaclos added the S-Help-wanted Status: you're familiar with the code base and want to help the project label Aug 30, 2023
@ditorodev
Copy link
Contributor

ditorodev commented Sep 1, 2023

Update: Currently getting used to it. @Conaclos has pointed me to some good example rules that I could use as reference but this weekend I don't have much time to keep trying. From Wednesday next week ill get a lot more time to try implementing this

Resources

conaclos — 08/30/2023 10:31 PM
You can take a look to an existing rule: https://github.com/biomejs/biome/blob/main/crates/rome_js_analyze/src/analyzers/suspicious/no_duplicate_class_members.rs#L101

conaclos — 08/30/2023 10:31 PM
There is no specific method is_static.
You have to traverse the modifiers of a member and look for the static modifier
Another example: https://github.com/biomejs/biome/blob/main/crates/rome_js_analyze/src/semantic_analyzers/nursery/use_naming_convention.rs#L677

conaclos — 08/30/2023 10:38 PM
You shoudl also take a look at no_setter_return.rs. This could help you 🙂

@ditorodev
Copy link
Contributor

This week im back at actively trying this 🤞

@ditorodev
Copy link
Contributor

Been making amazing progress here, check the PR #366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants