🐛 useExhaustiveDependencies: false positive for out of scope dependency

[emab]

Environment information

CLI:
  Version:                      1.3.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "cygwin"
  JS_RUNTIME_VERSION:           "v18.12.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       unset

Workspace:
  Open Documents:               0

What happened?

When using a variable declared outside of the component scope, you should not add it to a React useEffect dependency array. A valid example of this in the React docs:

• https://react.dev/learn/you-might-not-need-an-effect#initializing-the-application

ESLint is aware of this, and gives a warning if it is added:

ESLint: React Hook useEffect has an unnecessary dependency: 'hasRequested'. Either exclude it or remove the dependency array. Outer scope values like 'hasRequested' aren't valid dependencies because mutating them doesn't re-render the component.(react-hooks/exhaustive-deps)

However Biome falsely tells you to add it as a dependency:

https://biomejs.dev/playground/?lintRules=all&code=aQBtAHAAbwByAHQAIAB7AHUAcwBlAEUAZgBmAGUAYwB0AH0AIABmAHIAbwBtACAAJwByAGUAYQBjAHQAJwA7AAoACgBsAGUAdAAgAGQAaQBkAEkAbgBpAHQAIAA9ACAAZgBhAGwAcwBlADsACgAKAGYAdQBuAGMAdABpAG8AbgAgAEEAcABwACgAKQAgAHsACgAgACAAdQBzAGUARQBmAGYAZQBjAHQAKAAoACkAIAA9AD4AIAB7AAoAIAAgACAAIABpAGYAIAAoACEAZABpAGQASQBuAGkAdAApACAAewAKACAAIAAgACAAIAAgAGQAaQBkAEkAbgBpAHQAIAA9ACAAdAByAHUAZQA7AAoAIAAgACAAIAAgACAALwAvACAABScgAE8AbgBsAHkAIAByAHUAbgBzACAAbwBuAGMAZQAgAHAAZQByACAAYQBwAHAAIABsAG8AYQBkAAoAIAAgACAAIAB9AAoAIAAgAH0ALAAgAFsAXQApADsACgAgACAALwAvACAALgAuAC4ACgB9AA%3D%3D

Expected result

You should not be prompted to add an out-of-scope variable to the dependency array.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[ematipico]

Duplicate of #608

[emab]

Duplicate of #608

I don't think this is a duplicate of that issue?

[ematipico]

Apologies!

[kalleep]

I can pick this one up