Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove unused dependencies #2153

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

Kenzo-Wada
Copy link
Contributor

@Kenzo-Wada Kenzo-Wada commented Mar 21, 2024

Summary

Closes: #2136

ran cargo shear --fix and did some fixes (cargo-shear still had some bugs)

Test Plan

  • jest ready

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages labels Mar 21, 2024
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit ac7a9cc
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65fc622a9fa3fc000823e05e
😎 Deploy Preview https://deploy-preview-2153--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Kenzo-Wada Kenzo-Wada changed the title Chore/remove unused dependencies Chore: remove unused dependencies Mar 21, 2024
Copy link

codspeed-hq bot commented Mar 21, 2024

CodSpeed Performance Report

Merging #2153 will improve performances by 6.53%

⚠️ No base runs were found

Falling back to comparing Kenzo-Wada:chore/remove-unused-dependencies (ac7a9cc) with main (958a9a1)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main Kenzo-Wada:chore/remove-unused-dependencies Change
db.json[cached] 75.7 ms 71 ms +6.53%

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I found only a false positive that we should revert

Comment on lines 76 to 77
docgen = ["bpaf/docgen"]
format_css = ["biome_css_formatter/format_css"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug in shear, we need to keep it. Thank you :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed at ac7a9cc!

@ematipico ematipico merged commit 644d2f4 into biomejs:main Mar 21, 2024
14 of 16 checks passed
ematipico pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Core Area: core A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Remove unused dependencies
2 participants