Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css_parser): add parsing css modules @value at rule #2985

Merged
merged 7 commits into from
May 27, 2024

Conversation

denbezrukov
Copy link
Contributor

@denbezrukov denbezrukov commented May 25, 2024

Summary

Close #2984

  • Implement parsing for the @value at-rule
  • Add a new option for CSS parsing: css_modules

Test Plan

cargo test

@github-actions github-actions bot added A-Project Area: project A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-CSS Language: CSS labels May 25, 2024
@denbezrukov denbezrukov changed the title feat(css_parser): Add parsing css modules @value at rule feat(css_parser): add parsing css modules @value at rule May 25, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13441 13441 0
Failed 4205 4205 0
Panics 0 0 0
Coverage 76.17% 76.17% 0.00%

Copy link

codspeed-hq bot commented May 25, 2024

CodSpeed Performance Report

Merging #2985 will not alter performance

Comparing feat/css-module-at-rule-value (3752c67) with main (fec262f)

Summary

✅ 92 untouched benchmarks

@denbezrukov denbezrukov merged commit e52084a into main May 27, 2024
16 checks passed
@denbezrukov denbezrukov deleted the feat/css-module-at-rule-value branch May 27, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

values-variables
2 participants