-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint/useValidAutocomplete): add rule #3143
Conversation
wip feat: implement update snpashot Fix docs and option name Restore unrelated changes Restore unrelated changes
12e52f5
to
5bbf1ee
Compare
CodSpeed Performance ReportMerging #3143 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great rule! I just left one comment
#[cfg_attr(feature = "schema", derive(schemars::JsonSchema))] | ||
#[serde(rename_all = "camelCase", deny_unknown_fields)] | ||
pub struct UseValidAutocompleteOptions { | ||
pub input_components: Vec<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add doc comments to public options. These comments will appear in the JSON schema of the user
Summary
Closes #3037
Implement
autocomplete-valid
in jsx-a11y: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/autocomplete-valid.mdTest Plan
autocomplete-appropriate