Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint/useValidAutocomplete): add rule #3143

Merged
merged 14 commits into from
Jun 12, 2024

Conversation

unvalley
Copy link
Member

@unvalley unvalley commented Jun 10, 2024

Summary

Closes #3037

Implement autocomplete-valid in jsx-a11y: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/autocomplete-valid.md

Test Plan

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-CLI Area: CLI labels Jun 10, 2024
wip

feat: implement

update snpashot

Fix docs and option name

Restore unrelated changes

Restore unrelated changes
Copy link

codspeed-hq bot commented Jun 10, 2024

CodSpeed Performance Report

Merging #3143 will not alter performance

Comparing unvalley:use-valid-autocomplete (5def85f) with main (d2b08d1)

Summary

✅ 90 untouched benchmarks

@github-actions github-actions bot added the A-Changelog Area: changelog label Jun 10, 2024
@unvalley unvalley marked this pull request as ready for review June 10, 2024 17:45
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great rule! I just left one comment

#[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
#[serde(rename_all = "camelCase", deny_unknown_fields)]
pub struct UseValidAutocompleteOptions {
pub input_components: Vec<String>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add doc comments to public options. These comments will appear in the JSON schema of the user

@unvalley unvalley merged commit 0d9b60a into biomejs:main Jun 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement jsx-a11y/autocomplete-valid - useValidAutocomplete
3 participants