Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are broken because of NCBI side metadata changes (again) #18

Closed
bmpvieira opened this issue Feb 21, 2016 · 2 comments
Closed

Tests are broken because of NCBI side metadata changes (again) #18

bmpvieira opened this issue Feb 21, 2016 · 2 comments
Assignees
@bmpvieira
Labels
bug
Projects
Bionode Project Board
Milestone
1.8.0

Comments

@bmpvieira
Copy link
Member

Probably easy to fix (just update the tests data) but right now I can't look into it.
We could maybe as a long term solution use some mock framework to replicate the current NCBI expected behaviour and not rely and any specific metadata.
@bmpvieira
Copy link
Member Author

This could be useful to mock NCBIs API:
http://unexpected.js.org/unexpected-mitm

It seems it can generate the mock automatically and also check that it's in sync with the real API.

@bmpvieira bmpvieira added this to Backlog in Bionode Project Board Mar 29, 2017
@bmpvieira bmpvieira added the bug label Mar 29, 2017
@bmpvieira bmpvieira moved this from Backlog to Next in Bionode Project Board Mar 29, 2017
@bmpvieira bmpvieira self-assigned this Apr 6, 2017
@bmpvieira
Copy link
Member Author

Using Flet/tape-nock instead to record and later mock NCBI connections.

@bmpvieira bmpvieira moved this from Next to In Progress in Bionode Project Board Apr 6, 2017
bmpvieira added a commit that referenced this issue Apr 6, 2017
@bmpvieira
Add fixtures for mocking NCBI API fixing #18
2df164b
bmpvieira added a commit that referenced this issue Apr 6, 2017
@bmpvieira
Add fixtures for mocking NCBI API and fix #18
7ce840b
@bmpvieira bmpvieira added this to the 1.8.0 milestone Apr 7, 2017
bmpvieira added a commit that referenced this issue Apr 9, 2017
@bmpvieira
Merge pull request #21 from bionode/development
096fec8 
Fix tests (#18) and mocking NCBI API
@bmpvieira bmpvieira moved this from In Progress to Done in Bionode Project Board Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmpvieira bmpvieira

Labels
bug
Projects
Bionode Project Board
  
Done
Milestone
1.8.0
Development

No branches or pull requests
1 participant
@bmpvieira