Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smaller download assembly for testing and fix #24 #27

Merged
merged 1 commit into from
Apr 15, 2017
Merged

Add smaller download assembly for testing and fix #24 #27

merged 1 commit into from
Apr 15, 2017

Conversation

tiagofilipe12
Copy link
Member

This branch re-adds the functionality for download testing with a much smaller file 42.2kb instead of the previous 25 Mb.

@bmpvieira bmpvieira self-requested a review April 15, 2017 18:39
@bmpvieira bmpvieira added the test label Apr 15, 2017
@bmpvieira bmpvieira added this to the 1.8.0 milestone Apr 15, 2017
bmpvieira
bmpvieira approved these changes Apr 15, 2017
View reviewed changes
Copy link
Member

@bmpvieira bmpvieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to find a smaller assembly and re-enabling these tests!

@tiagofilipe12 tiagofilipe12 merged commit b4a2da5 into master Apr 15, 2017
@tiagofilipe12 tiagofilipe12 deleted the new_file branch April 18, 2017 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmpvieira bmpvieira bmpvieira approved these changes

Assignees

@tiagofilipe12 tiagofilipe12

Labels
test
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagofilipe12 @bmpvieira