-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regular expressions containing redundant prefix and update local identifier validation #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
changed the title
Update identifier validation to rely on shortened identifiers
Fix regular expressions containing redunant prefix and update local identifier validation
Oct 11, 2021
1 task
cthoyt
changed the title
Fix regular expressions containing redunant prefix and update local identifier validation
Fix regular expressions containing redundant prefix and update local identifier validation
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191
This PR does two things:
This PR will not be merged until there is a consensus on this. I will bring it up in discussion at the Fall 2021 Workshop on Prefixes, CURIEs, and IRIs which is on October 29th, then give everyone about a week to give feedback.See also #214 where the web UI is updated to better convey the difference between a regular expression pattern that's for a local identifier versus for a compact URI (i.e., CURIE), which must, by definition, contain the prefix.