Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bwa wrapper #167

Closed
wants to merge 8 commits into from
Closed

Bwa wrapper #167

wants to merge 8 commits into from

Conversation

saketkc
Copy link
Contributor

@saketkc saketkc commented Mar 5, 2013

Made a wrapper for BWA(http://bio-bwa.sourceforge.net). Added few unittests. Also the Bio.Applications call method, has been now modified to allow file writes by passing an argument to stdout/stderr as a file location.

@peterjc
Copy link
Member

peterjc commented Mar 28, 2013

Progress report - I've made a similar but more general change to the call method on the main branch,
c4a5796

I will take care of merging your work on top of this (so you don't need to worry about updating this branch) when I can find a suitable moment.

@peterjc
Copy link
Member

peterjc commented Apr 11, 2013

OK, that's been applied to the master - thanks :)
ea6a55f

One catch was you also need to explicitly add the doctests to the list in run_tests.py,
d896509

Related to that writing doctests for command line wrappers is tricky, see:
4351be5

Also the class docstrings were repeating all the property docstrings, so it was redundant:
6c37fe7

Finally I think the unit tests could be improved a little - there are some handle leaks, see this discussion:
http://lists.open-bio.org/pipermail/biopython-dev/2013-April/010521.html

But anyway - your first major contribution to Biopython will be in the next release, thank you :)
6712d17

@peterjc peterjc closed this Apr 11, 2013
@peterjc
Copy link
Member

peterjc commented Apr 12, 2013

I fixed the handle leak in this commit, where the main aim was clearer failure messages (the test was failing on some of the buildslaves):
0c6224b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants