Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unitest assertEquals to assertEqual #4345

Merged
merged 3 commits into from
Jul 1, 2023
Merged

Conversation

sagitter
Copy link
Contributor

@sagitter sagitter commented Jul 1, 2023

  • I hereby agree to dual licence this and any previous contributions under both
    the Biopython License Agreement AND the BSD 3-Clause License.

  • I have read the CONTRIBUTING.rst file, have run pre-commit
    locally, and understand that continuous integration checks will be used to
    confirm the Biopython unit tests and style checks pass with these changes.

  • I have added my name to the alphabetical contributors listings in the files
    NEWS.rst and CONTRIB.rst as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

Closes #4334

@sagitter sagitter requested a review from mdehoon as a code owner July 1, 2023 12:32
@peterjc
Copy link
Member

peterjc commented Jul 1, 2023

Thanks - I'll squash-and-merge this into a single commit once the tests had run (which should be a formality, I expect them to pass).

@peterjc peterjc self-requested a review July 1, 2023 12:39
@peterjc peterjc changed the title Fix issue #4334 unitest assertEquals to assertEqual Jul 1, 2023
@mdehoon mdehoon merged commit 61417d0 into biopython:master Jul 1, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'TestURLConstruction' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
3 participants