Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for redmine 2.x and add configurable default landing pages #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dro123
Copy link

@dro123 dro123 commented Sep 28, 2012

These 2 commits add support for redmine 2.x and allow the
redmine admin to setup global default landing pages for
redmine and projects that don't have landing pages defined.

Signed-off-by: Tobias Droste <tdroste@gmx.de>
This adds configurable default landing pages for redmine
and projects that don't have a landing page defined.

If nothing is defined as a landing page the redmine
defaults are used.

There's a small change in behaviour that makes the original
landing pages work again if they are called directly, so
no functionality is lost when using landing pages.

Additionally to be more robust to server changes allow
relatives URLs to reference modules in the same project/scope

Signed-off-by: Tobias Droste <tdroste@gmx.de>
@balderdk
Copy link

Good job man, hoping it gets added :)

@logical-and
Copy link

Guys, use this branch. https://github.com/hicknhack-software/redmine_time_tracker
Its up to date.

@dro123
Copy link
Author

dro123 commented Oct 11, 2012

That's not the same plugin!?

@logical-and
Copy link

Oops. =) Sorry, I was wrong with the notification title. Anyway, I this fork on currrent redmine trunk. It is - https://github.com/srathbun/redmine_landing_page.
@dro123 Can you merge that fork, so your fork can be newest after. Additionally, would be nice if you implement some feature - #7 (comment). No one has it. =)

@dro123
Copy link
Author

dro123 commented Oct 11, 2012

That issue (#7) is solved with the second commit. The first commit fixes issue #5 (with still maintaining compatibility with redmine 1.3 and 1.4).

@dro123
Copy link
Author

dro123 commented Oct 11, 2012

Regarding https://github.com/srathbun/redmine_landing_page:

My changes makes the changes done there obsolete by doing the same (and more) but differently.

@logical-and
Copy link

OK, I'll check it out later. Thanks for these commits, Tobias.

Signed-off-by: Tobias Droste <tdroste@gmx.de>
@dro123
Copy link
Author

dro123 commented Oct 13, 2012

Since biow0lf doesn't seem to be interested in this plugin anymore I also sent the changes to srathbun

@voidzero
Copy link

What's the status, Stratus?

@dro123
Copy link
Author

dro123 commented May 14, 2014

just use this one: https://github.com/srathbun/redmine_landing_page

@voidzero
Copy link

Thanks @dro123 for the advice. I tried that plugin, I can see the configuration settings in both the Admin settings and profile settings but whatever I configure doesn't get picked up, even after restarting the webserver. I am using thin. Redmine behaves the same as always. I'm on redmine 2.5.1.

I'm writing this here because there is no issue tracker on the other page.

@dro123
Copy link
Author

dro123 commented May 15, 2014

Works fine here with Redmine 2.5.1. Are you sure you ran rake redmine:plugins:migrate?

@voidzero
Copy link

Yeah, I'm sure. Do you use relative links (like /projects/foobar/activity) or absolute links (http://...)?

@dro123
Copy link
Author

dro123 commented May 15, 2014

relative links (make sure they don't include the / in front!) and absolute links are working here.

Rails 4 disallows 'match' in routes.rb without specifying the http method.
Replace all 'match' with 'get'.

Signed-off-by: Tobias Droste <tdroste@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants