-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make this library browser usable #6
base: master
Are you sure you want to change the base?
Conversation
Added some bits to isolate the code from the browser (that doesn't affect node at all) and put some checks in place to see if the file is being run in a browser or in node. The way you use it in node is the same, however now you can also use it in a browser as its globaled as jspack AKA this.jspack. Simply load jspack.js in a browser and type jspack in the developer console to test.
Sorry forgot to update the test so travis went nuts.
@kmpm let me know if you have any concerns. |
You do not put spaces there.
@kmpm Just noticed that _DeString fails to loop through the entire array. What is even the point of <s if it will only return the first letter and nothing else. |
You are right about the issues you have found. Could you please create I'm on vacation this week and might not be able to do any coding but thanks
|
Also i use this library in actual development and these 3 issues are the only things holding up development for one of my libraries @kmpm |
@kmpm >.> |
Added some bits to isolate the code from the browser (that doesn't affect node at all) and put some checks in place to see if the file is being run in a browser or in node.
The way you use it in node is the same, however now you can also use it in a browser as its globaled as jspack AKA this.jspack.
Simply load jspack.js in a browser and type jspack in the developer console to test.