Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this library browser usable #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

belldandu
Copy link

Added some bits to isolate the code from the browser (that doesn't affect node at all) and put some checks in place to see if the file is being run in a browser or in node.

The way you use it in node is the same, however now you can also use it in a browser as its globaled as jspack AKA this.jspack.

Simply load jspack.js in a browser and type jspack in the developer console to test.

Added some bits to isolate the code from the browser (that doesn't affect node at all) and put some checks in place to see if the file is being run in a browser or in node.

The way you use it in node is the same, however now you can also use it in a browser as its globaled as jspack AKA this.jspack.

Simply load jspack.js in a browser and type jspack in the developer console to test.
Sorry forgot to update the test so travis went nuts.
@belldandu
Copy link
Author

@kmpm let me know if you have any concerns.

You do not put spaces there.
@belldandu
Copy link
Author

@kmpm Just noticed that _DeString fails to loop through the entire array. What is even the point of <s if it will only return the first letter and nothing else.

@kmpm
Copy link
Member

kmpm commented Jun 26, 2016

You are right about the issues you have found. Could you please create
separate issues for them if they are not directly related to each other or
this browser issue.

I'm on vacation this week and might not be able to do any coding but thanks
for contributing. I haven't used this module for some time but that's not a
reason to not improving it.
Den 26 juni 2016 10:47 fm skrev "Belldandu" notifications@github.com:

@kmpm https://github.com/kmpm Just noticed that _DeString fails to loop
through the entire array. What is even the point of <s if it will only
return the first letter and nothing else.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAF5ardv9APRBB8zPNm9Qh_xqpEuUsLLks5qPjyMgaJpZM4I-fLb
.

@belldandu
Copy link
Author

@kmpm #5 #7 #8

Still waiting for a response.

@belldandu
Copy link
Author

Also i use this library in actual development and these 3 issues are the only things holding up development for one of my libraries @kmpm

@belldandu
Copy link
Author

@kmpm >.>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants