-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add humidex calc #280
Add humidex calc #280
Conversation
for more information, see https://pre-commit.ci
Local tests are failing but might be due to updated xclim to
|
Yeah indeed... You'll need to translate all those "*_series" to calls of https://xclim.readthedocs.io/en/v0.43.0/xclim.testing.html#xclim.testing.helpers.test_timeseries. You might get inspiration from xscen's brand new test modules : https://github.com/Ouranosinc/xscen/blob/9b070c79762de28007f034743c25fffe52904900/tests/test_aggregate.py |
requirements_docs.txt
Outdated
@@ -2,7 +2,7 @@ pywps>=4.5.1 | |||
sphinx>=4.0 | |||
nbsphinx | |||
ipython | |||
xclim==0.38 | |||
xclim==0.43 | |||
pint<0.20 # xclim < 0.39 breaks with pint 0.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aulemahal indicated that xclim is always pinned in finch?
Also if I wait for #272 then integrate changes will the tests fix themselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm talking specifically the pint
pin, sorry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging should fix failures related to h5netcdf and the subset notebook, but not the ones from the "*_series" test helpers, these come from a change posterior to 0.40 (the xclim in 272).
environment.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to put an upper pin on python
here. Python3.11 is not officially support with some libraries.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into add_humidex_calc
for more information, see https://pre-commit.ci
…into add_humidex_calc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good overall!
A few changes requested.
This is also missing some documentation, principally in docs/source/configuration.rst
.
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Added some info to the configuration.rst let me know if it seems ok |
Overview
This PR fixes #278
Changes:
HXmax
in this case)Additional Information
Adding french metadata to the humidex yml could be useful