Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/enforce max startup power 2 #165

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

damosvil
Copy link
Contributor

In 0.19 max startup power was enforced during startup phases using temperature protection.
This unadverted feature was removed when fixing 3d bidirectional mode.
This bugfix reenables this protection.

@damosvil damosvil changed the base branch from main to v0.20.1 August 21, 2023 18:17
@damosvil damosvil self-assigned this Aug 21, 2023
@damosvil damosvil added the fix label Aug 21, 2023
@damosvil damosvil added this to the v0.20.1 milestone Aug 21, 2023
@damosvil damosvil linked an issue Aug 21, 2023 that may be closed by this pull request
@github-actions
Copy link

Build artifacts:

@stylesuxx stylesuxx merged commit e448b5a into v0.20.1 Aug 21, 2023
1 check passed
@hyp0dermik-code
Copy link
Contributor

This behavior may have been intentional because of the choice between stuck or burnt.

  • What do the majority of users expect?
  • Can we accommodate for a different limit for turtle mode?
  • At a minimum, can this feature be enabled/disabled

@stylesuxx
Copy link
Contributor

@hyp0dermik-code Users will rather expect this behaviour since it is what they are used to.

Different settings for turtle mode can be discussed, but not as a Bugfix, rather a "full" feature.

@stylesuxx stylesuxx deleted the bugfix/enforce_max_startup_power_2 branch July 23, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 failed ESCs on bluejay 0.20.0
3 participants