Porting/v0.20.1 fixes #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the esc/motor durign startup. This has an special effect on crashes because max power was not limited during startup phases Fixed some bugs Fixed review comments Fixed review findings Removed unnecesary initialization in exit_run_mode before jumping to motor_start
Pwm_Limit_By_Rpm allowance removed from inital_run_phase_done to pwm limit by rpm will increase in set_pwm_limit function Reenabled rampup during initial run phase
damosvil
added
bug
hyp0dermik-code
approved these changes
Sep 23, 2023
stylesuxx
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepared this pr with the fixes made for 0.20.1