Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📝 add docs to custom render method #209

Conversation

dennemark
Copy link

Add documentation to custom render method - Discussion: maplibre#3136 (comment)

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.57%. Comparing base (4046e53) to head (20af33f).
Report is 1 commits behind head on expose-projection-matrix-params.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           expose-projection-matrix-params     #209      +/-   ##
===================================================================
- Coverage                            87.68%   87.57%   -0.11%     
===================================================================
  Files                                  242      242              
  Lines                                33085    33092       +7     
  Branches                              2171     2314     +143     
===================================================================
- Hits                                 29009    28981      -28     
- Misses                                3083     3117      +34     
- Partials                               993      994       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennemark
Copy link
Author

@birkskyum did you find time to look at this already? i think afterwards the PR on malibre repo is nearly ready to go. not sure about tests though...

@birkskyum birkskyum merged commit 155e258 into birkskyum:expose-projection-matrix-params Jun 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants