Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

List MaxCoin (MAX) #10

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2018

Copy link
Collaborator

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK per comments


package bisq.asset.coins;

import bisq.asset.RegexAddressValidator;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid import ordering

@cbeams cbeams assigned ghost May 15, 2018
@ghost
Copy link
Author

ghost commented May 19, 2018

Hi, please let me know if the changes for the conflict are valid, it looks like a single line to insert that should be safe to insert, but one further consideration I've probably not done the ideal thing for the commit.

@blabno
Copy link
Collaborator

blabno commented May 21, 2018

@Buckshee fix conflicts and squash commits into single one.

@ghost ghost force-pushed the list-maxcoin-asset branch from 8987168 to 547557e Compare May 21, 2018 10:10
@blabno
Copy link
Collaborator

blabno commented May 29, 2018

@Buckshee I have reorganized imports for you to match our code style. Please rebase this PR and squash commits into single one.

@ghost ghost force-pushed the list-maxcoin-asset branch from 9480602 to 59e3f1e Compare June 4, 2018 08:55
@cbeams cbeams merged commit db9eea6 into bisq-network:master Jun 5, 2018
@ghost ghost mentioned this pull request Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants