Add support for CryptoTari; add Stellar token address validator #19
Conversation
| public static String getText(String url) throws Exception { | ||
| URL website = new URL(url); | ||
| URLConnection connection = website.openConnection(); | ||
| BufferedReader in = new BufferedReader( |
There was a problem hiding this comment.
I don't think we want to make any external queries to validate anything.
Validation must work offline.
There was a problem hiding this comment.
External requests are not permitted!
There was a problem hiding this comment.
Thank you for the quick response.
I understand your position, but let me explain the situation a bit more so you may reconsider.
The ripple/stellar network works in a way that there is no way to tell offline whether a specific address can receive a specific token or not (an account needs to set up a "trust line" before it can hold a specific token).
We could validate the address syntax offline but if someone would buy the token without the established trust line then the seller would not be able to transfer the tokens even if he/she wanted to and the deal would go straight to arbitration (as the seller could not contact the buyer directly to tell him/her to establish the needed trust).
Given the above would you reconsider the rejection - or suggest an alternative?
Thanks!
There was a problem hiding this comment.
Thanks for the explanation. I still would prefer than the offline online validation and risk some arbitration cases rather to can clear-net URL connections. All network connection in Bisq run over Tor to avoid leaking the IP via clear-net calls.
There was a problem hiding this comment.
Thank you, I got your point now. I will make a new pull request with offline validation.
ghost
mentioned this pull request
The address validator is designed to be reusable by other stellar tokens.