Rework download links #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 4, 2018 10:53
For Windows and Linux.
Only in current/collapsed dropdown selection.
Fixes inconsistent highlighting in download link list.
No rpm binaries, so just take those users to /downloads.
Somewhat messy code was resulting in sneaky errors, now fixed: - download links not working on firefox altogether (!) - ios thinking it's ios and macos at the same time - inconsistent os selection highlighting Since the top of the front page is literally the first experience most people will have with Bisq, I figured it worthwhile to spend the time to get it right.
Added analytics js snippet; console errors gone, need someone with access to Google Analytics to verify it's actually working.
|
@m52go Looks good to me in the preview! But it seems that you have a conflict that needs to be resolved. |
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found issues with download links:
Other notable changes:
So I spent some time yesterday reworking the code and UI for download links. While seemingly minor I figured it worth the time because getting users to download the Bisq software is probably our #1 goal for the website, and it should be a flawless experience.
@ripcurlx if you or someone with access to Analytics can verify that analytics are working again, that would be great. I was getting ga errors before, and I'm not getting them any more, but I can't be 100% sure events are actually being recorded on the server.