List Navcoin (NAV) #2527
Merged
List Navcoin (NAV) #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blabno
suggested changes
Mar 11, 2019
|
|
||
| public class Navcoin extends Coin { | ||
| public Navcoin() { | ||
| super("Navcoin", "NAV", new Base58BitcoinAddressValidator(new NavcoinMainNetParams()), Network.MAINNET); |
There was a problem hiding this comment.
Remove Network.MAINNET param as it is the default value.
There was a problem hiding this comment.
just squash the commits into a single one
aguycalled
force-pushed
the
list-navcoin
branch
from
62f5aef
to
33b04fb
Compare
|
@aguycalled fix the commit message to be aligned with the documentation, or grant me an access to your fork and I'll do that |
aguycalled
force-pushed
the
list-navcoin
branch
from
33b04fb
to
ad44ca5
Compare
|
@blabno fixed. granted you access too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes necessary to re-enable support of Navcoin in Bisq.
Many community members expressed their interest in seeing the coin supported again after the implementation of the last new features like Community Fund, Cold Staking or the novel privacy method ZeroCT.