Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Navcoin (NAV) #2527

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
4 participants
@aguycalled
Copy link
Contributor

commented Mar 11, 2019

This PR includes the changes necessary to re-enable support of Navcoin in Bisq.
Many community members expressed their interest in seeing the coin supported again after the implementation of the last new features like Community Fund, Cold Staking or the novel privacy method ZeroCT.

@blabno
Copy link
Contributor

left a comment

NACK per comments


public class Navcoin extends Coin {
public Navcoin() {
super("Navcoin", "NAV", new Base58BitcoinAddressValidator(new NavcoinMainNetParams()), Network.MAINNET);

This comment has been minimized.

Copy link
@blabno

blabno Mar 11, 2019

Contributor

Remove Network.MAINNET param as it is the default value.

This comment has been minimized.

Copy link
@aguycalled

aguycalled Mar 11, 2019

Author Contributor

This comment has been minimized.

Copy link
@blabno

blabno Mar 11, 2019

Contributor

just squash the commits into a single one

@aguycalled aguycalled force-pushed the aguycalled:list-navcoin branch from 62f5aef to 33b04fb Mar 11, 2019

@blabno

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@aguycalled fix the commit message to be aligned with the documentation, or grant me an access to your fork and I'll do that

@aguycalled aguycalled force-pushed the aguycalled:list-navcoin branch from 33b04fb to ad44ca5 Mar 19, 2019

@aguycalled

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

@blabno fixed. granted you access too

@blabno

blabno approved these changes Mar 19, 2019

Copy link
Contributor

left a comment

ACK

@ripcurlx ripcurlx merged commit 68f7aad into bisq-network:master Mar 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.