Bitcoin p2p: Use different timeouts #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message exchange.
ManfredKarrer
changed the title
|
As we are in release preparations we have code freeze, so I set it to WIP to not get merged by accident. |
ripcurlx
changed the title
|
FYI we will delay all not DAO related PR after DAO launch. |
ManfredKarrer
changed the title
ManfredKarrer
approved these changes
May 14, 2019
| @@ -87,7 +87,9 @@ | |||
| // Does the basic wiring | |||
| @Slf4j | |||
| public class WalletConfig extends AbstractIdleService { | |||
| private static final int TIMEOUT = 120 * 1000; // connectTimeoutMillis. 60 sec used in bitcoinj, but for Tor we allow more. | |||
| private static final int TOR_SOCKET_TIMEOUT = 120 * 1000; // 1 sec used in bitcoinj, but since bisq uses Tor we allow more. | |||
| private static final int TOR_VERSION_EXCHANGE_TIMEOUT = 125 * 1000; // 5 sec used in bitcoinj, but since bisq uses Tor we allow more. | |||
There was a problem hiding this comment.
Is it intended to just have a slightly diff. value to TOR_SOCKET_TIMEOUT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitcoin p2p: Use different timeouts for socket connection and version message exchange.
Version message exchange timeout should be greater than socket connection timeout.