Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add protection tools #2787

Closed
wants to merge 58 commits into from
Closed

[WIP] Add protection tools #2787

wants to merge 58 commits into from

Commits on Apr 21, 2019

  1. Merge branch 'fix-trade-peers-account-age' into delay-payout-if-fait-… 

    …buyer-has-new-account
    @ManfredKarrer
    ManfredKarrer committed Apr 21, 2019
    Configuration menu
    Copy the full SHA
    c2757db View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2019

  1. Fix wrong display of ages with 1 at the end (e.g. 31 days) 

    31 days was displayed as 31 day.
    @ManfredKarrer
    ManfredKarrer committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    29ff2fc View commit details
    Browse the repository at this point in the history

  2. Add min required buyers account age 

    Implements bisq-network/proposals#77

If fiat trade the buyer need to have an min required account age,
otherwise the payout will be delayed.
    @ManfredKarrer
    ManfredKarrer committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    a314416 View commit details
    Browse the repository at this point in the history

  3. Add warning popup to offer book

    @ManfredKarrer
    ManfredKarrer committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    72be262 View commit details
    Browse the repository at this point in the history

  4. Remove rounded fiat amounts popup 

    I think the features is now well known and can be removed.
The account age check will add a nde popup so we would get more popup
hell if we leave that one...
    @ManfredKarrer
    ManfredKarrer committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    e74aad7 View commit details
    Browse the repository at this point in the history

  5. Add popup to offer maker 

    If offer maker for buying BTC with Fiat has an account selected which is
less then the required account age for that method he gets a
popup displayed.
    @ManfredKarrer
    ManfredKarrer committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    4cae398 View commit details
    Browse the repository at this point in the history

  6. Refactor

    @ManfredKarrer
    ManfredKarrer committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    79ed168 View commit details
    Browse the repository at this point in the history

  7. Improve text

    @ManfredKarrer
    ManfredKarrer committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    a1e58a4 View commit details
    Browse the repository at this point in the history

  8. Handle trade period (WIP)

    @ManfredKarrer
    ManfredKarrer committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    b46e98f View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. Add more keys

    @ManfredKarrer
    ManfredKarrer committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    9e6989a View commit details
    Browse the repository at this point in the history

  2. Refactor: Move accountAgeWitness classes to new package

    @ManfredKarrer
    ManfredKarrer committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    8eab3f3 View commit details
    Browse the repository at this point in the history

  3. Refactor: Cleanup, no functionality change

    @ManfredKarrer
    ManfredKarrer committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    ca373ff View commit details
    Browse the repository at this point in the history

  4. Add SignedWitness domain (WIP)

    @ManfredKarrer
    ManfredKarrer committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    b20a60e View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2019

  1. Merge branch 'master' into delay-payout-if-fait-buyer-has-new-account 

    # Conflicts:
#	desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java
#	desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java
    @ManfredKarrer
    ManfredKarrer committed Apr 27, 2019
    Configuration menu
    Copy the full SHA
    0968861 View commit details
    Browse the repository at this point in the history

  2. Update strings

    @ManfredKarrer
    ManfredKarrer committed Apr 27, 2019
    Configuration menu
    Copy the full SHA
    99c271a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into sign-account-usage 

    # Conflicts:
#	core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java
#	desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java
    @ManfredKarrer
    ManfredKarrer committed Apr 27, 2019
    Configuration menu
    Copy the full SHA
    27d7656 View commit details
    Browse the repository at this point in the history

  4. Fix wrong imports

    @ManfredKarrer
    ManfredKarrer committed Apr 27, 2019
    Configuration menu
    Copy the full SHA
    ce99f56 View commit details
    Browse the repository at this point in the history

  5. Refactoring: Move classed to new package 

    Pure technical refactoring, no functionality change.
    @ManfredKarrer
    ManfredKarrer committed Apr 27, 2019
    Configuration menu
    Copy the full SHA
    a28c728 View commit details
    Browse the repository at this point in the history

  6. Add Account score domain (WIP) 

    Move methods for delayed payout to AccountScore.
    @ManfredKarrer
    ManfredKarrer committed Apr 27, 2019
    Configuration menu
    Copy the full SHA
    e6d4709 View commit details
    Browse the repository at this point in the history

  7. Refactor: Move methods to domain (WIP)

    @ManfredKarrer
    ManfredKarrer committed Apr 27, 2019
    Configuration menu
    Copy the full SHA
    9c02ef8 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2019

  1. Move account age related code to AccountCreationAgeService 

    We use AccountScoreService as main class which constructs the
parameters based on several protection tools. Currently there is only
account age based protection.
    @ManfredKarrer
    ManfredKarrer committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    ca6843c View commit details
    Browse the repository at this point in the history

  2. Fix delay function, refactorings

    @ManfredKarrer
    ManfredKarrer committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    eb1899f View commit details
    Browse the repository at this point in the history

  3. Rename method

    @ManfredKarrer
    ManfredKarrer committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    765c708 View commit details
    Browse the repository at this point in the history

  4. Add methods for getting the AccountScoreCategory

    @ManfredKarrer
    ManfredKarrer committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    8d6267d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'sign-account-usage' into add-protection-tools 

    # Conflicts:
#	core/src/main/java/bisq/core/app/BisqSetup.java
#	core/src/main/java/bisq/core/app/misc/AppSetupWithP2P.java
#	core/src/main/java/bisq/core/app/misc/AppSetupWithP2PAndDAO.java
#	core/src/main/java/bisq/core/offer/OfferUtil.java
#	core/src/main/java/bisq/core/proto/CoreProtoResolver.java
#	core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java
#	core/src/main/java/bisq/core/trade/Trade.java
#	core/src/main/java/bisq/core/trade/TradeManager.java
#	core/src/main/java/bisq/core/trade/TradeModule.java
#	core/src/main/java/bisq/core/trade/protocol/ProcessModel.java
#	core/src/main/java/bisq/core/trade/protocol/tasks/VerifyPeersAccountAgeWitness.java
#	desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java
#	desktop/src/main/java/bisq/desktop/components/PeerInfoIconSmall.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/AdvancedCashForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/AliPayForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/AssetsForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/BankForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/CashDepositForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/ChaseQuickPayForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/ClearXchangeForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/F2FForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/FasterPaymentsForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralAccountNumberForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralBankForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralSepaForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/HalCashForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/InteracETransferForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyBeamForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyGramForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/NationalBankForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/PerfectMoneyForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/PopmoneyForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/PromptPayForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/SameBankForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaInstantForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/SpecificBankForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/SwishForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/USPostalMoneyOrderForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/UpholdForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/WeChatPayForm.java
#	desktop/src/main/java/bisq/desktop/components/paymentmethods/WesternUnionForm.java
#	desktop/src/main/java/bisq/desktop/main/MainViewModel.java
#	desktop/src/main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsDataModel.java
#	desktop/src/main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsView.java
#	desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsDataModel.java
#	desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java
#	desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java
#	desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java
#	desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModel.java
#	desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java
#	desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java
#	desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java
#	desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java
#	desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java
#	desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModelTest.java
#	desktop/src/test/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModelTest.java
    @ManfredKarrer
    ManfredKarrer committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    9a54dc3 View commit details
    Browse the repository at this point in the history

  6. Add arguments

    @ManfredKarrer
    ManfredKarrer committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    cbdb472 View commit details
    Browse the repository at this point in the history

  7. Apply organize imports 

    Pure technical refactoring, no functional code change
    @ManfredKarrer
    ManfredKarrer committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    f172fa6 View commit details
    Browse the repository at this point in the history

  8. Rename package 

    Pure technical refactoring, no functional code change
    @ManfredKarrer
    ManfredKarrer committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    e2b322f View commit details
    Browse the repository at this point in the history

  9. Handle AccountScoreCategory methods depending on signed witness state

    @ManfredKarrer
    ManfredKarrer committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    2c7b613 View commit details
    Browse the repository at this point in the history

  10. Add verify check

    @ManfredKarrer
    ManfredKarrer committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    60fcde6 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2019

  1. Apply new delay function, add ScoreInfo class and methods

    @ManfredKarrer
    ManfredKarrer committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    26fb30c View commit details
    Browse the repository at this point in the history

  2. Add UI for score info

    @ManfredKarrer
    ManfredKarrer committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    f9a756b View commit details
    Browse the repository at this point in the history

  3. Fix deposit function

    @ManfredKarrer
    ManfredKarrer committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    e6f7345 View commit details
    Browse the repository at this point in the history

  4. Adjust create offer popup with new scoreInfo data

    @ManfredKarrer
    ManfredKarrer committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    43b6238 View commit details
    Browse the repository at this point in the history

  5. Add popup for taker

    @ManfredKarrer
    ManfredKarrer committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    3fd133f View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2019

  1. Change buyer sec. deposit

    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    12a3d89 View commit details
    Browse the repository at this point in the history

  2. Change PERM_DELAY to 15 days, adjust tests

    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    248df21 View commit details
    Browse the repository at this point in the history

  3. Add requireAuthorizedTaker to offer and preferences

    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    a2454ac View commit details
    Browse the repository at this point in the history

  4. Add check and popup for offers requiring authorized takers 

    - Revert earlier changes which applied that check in the general
account check.
    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    8f519f3 View commit details
    Browse the repository at this point in the history

  5. Adjust column width

    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    c81142c View commit details
    Browse the repository at this point in the history

  6. Show restrictions based on payment method

    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    74344a8 View commit details
    Browse the repository at this point in the history

  7. Improve restrictions settings in create offer

    @ripcurlx
    ripcurlx committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    961870a View commit details
    Browse the repository at this point in the history

  8. Merge pull request #8 from ripcurlx/create-offer-improvements 

    Improve restrictions settings in create offer
    @ManfredKarrer
    ManfredKarrer authored Apr 30, 2019
    Configuration menu
    Copy the full SHA
    649c28a View commit details
    Browse the repository at this point in the history

  9. Add comment

    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    a989438 View commit details
    Browse the repository at this point in the history

  10. Add trade amount to SignedWitness 

    Even if we would not use it initially it might be good to have it for
potential future use.
    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    dbc1594 View commit details
    Browse the repository at this point in the history

  11. Rename put method to putIfAbsent to reflect behaviour better

    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    61d4d26 View commit details
    Browse the repository at this point in the history

  12. Rename put method to putIfAbsent to reflect behaviour better

    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    e52707f View commit details
    Browse the repository at this point in the history

  13. Add more comments

    @ManfredKarrer
    ManfredKarrer committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    c960520 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2019

  1. Add missing parameter

    @ripcurlx
    ripcurlx committed May 1, 2019
    Configuration menu
    Copy the full SHA
    a2d2fea View commit details
    Browse the repository at this point in the history

  2. Change icons

    @ripcurlx
    ripcurlx committed May 1, 2019
    Configuration menu
    Copy the full SHA
    4ac64a1 View commit details
    Browse the repository at this point in the history

  3. Extend trade protocol to support payout delay

    @ManfredKarrer
    ManfredKarrer committed May 1, 2019
    Configuration menu
    Copy the full SHA
    dedfd2e View commit details
    Browse the repository at this point in the history

  4. Add missing class

    @ManfredKarrer
    ManfredKarrer committed May 1, 2019
    Configuration menu
    Copy the full SHA
    6cbc311 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #9 from ripcurlx/change-icons 

    Change icons
    @ManfredKarrer
    ManfredKarrer authored May 1, 2019
    Configuration menu
    Copy the full SHA
    969c448 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2019

  1. Fix fiatReceivedDate handling

    @ManfredKarrer
    ManfredKarrer committed May 2, 2019
    Configuration menu
    Copy the full SHA
    b176bd6 View commit details
    Browse the repository at this point in the history

  2. Rename PeerInfoWithTagEditor to PeerInfoPopup

    @ManfredKarrer
    ManfredKarrer committed May 2, 2019
    Configuration menu
    Copy the full SHA
    997c032 View commit details
    Browse the repository at this point in the history

  3. Handle delayed payout in trade protocol (WIP)

    @ManfredKarrer
    ManfredKarrer committed May 2, 2019
    Configuration menu
    Copy the full SHA
    41b3f04 View commit details
    Browse the repository at this point in the history

  4. Add verify task, improve UI

    @ManfredKarrer
    ManfredKarrer committed May 2, 2019
    Configuration menu
    Copy the full SHA
    4494d07 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. Handle payout delay in trade process (WIP)

    @ManfredKarrer
    ManfredKarrer committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    3c24644 View commit details
    Browse the repository at this point in the history