Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant closing of connection #4056

Conversation

@ripcurlx
Copy link
Member

ripcurlx commented Mar 12, 2020

Fixes #4052, as the peer.close() already calls closeConnection if
a writeTarget is established successfully.

Copy link
Member

wiz left a comment

ACK
Tested and verifies it resolves my issue #4052 with v1.2.8

@ripcurlx

This comment has been minimized.

Copy link
Member Author

ripcurlx commented Mar 12, 2020

I tested with a Regtest Bitcoin Core with wrong configuration and on Mainnet with Bitcoin Core and everything works as expected on macOS.

@ripcurlx

This comment has been minimized.

Copy link
Member Author

ripcurlx commented Mar 12, 2020

But there still seems to be an issue on @wiz Linux setup.

Fixes #4052, as the peer.close() already calls closeConnection if
a writeTarget is established successfully.
@ripcurlx ripcurlx force-pushed the ripcurlx:fix-connection-closing-of-core-node-detection branch from 5bc3425 to e7a22f4 Mar 12, 2020
@Bisqtoshi

This comment has been minimized.

Copy link

Bisqtoshi commented Mar 12, 2020

Tested and works on macOS Catalina

@sqrrm
sqrrm approved these changes Mar 13, 2020
Copy link
Member

sqrrm left a comment

utACK

@sqrrm sqrrm merged commit 5a2d153 into bisq-network:master Mar 13, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx mentioned this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.