Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V3 seednode devinv3r #4320

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Conversation

devinbileck
Copy link
Member

As part of the Tor V3 upgrade, and the effort to increase the number of
Bisq seednodes from 8 to 12, this PR adds a new V3 seednode.

As part of the Tor V3 upgrade, and the effort to increase the number of
Bisq seednodes from 8 to 12, this PR adds a new V3 seednode.
wiz
wiz previously approved these changes Jun 24, 2020
Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - tested OK to block 636091

#################################################################
Connected to node: devinv3rhon24gqf5v6ondoqgyrbzyqihzyouzv7ptltsewhfmox2zqd.onion:8000
Received 1151 instances
RefundAgent: 1
Filter: 1
MailboxStoragePayload: 742
Mediator: 3
Alert: 1
OfferPayload: 403
################################################################# 

@sqrrm does this look okay or should we manually copy over some data from another seednode?

ripcurlx
ripcurlx previously approved these changes Jun 25, 2020
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - based on #4320 (review)

@ripcurlx
Copy link
Contributor

@devinbileck As I merged another ops branch before there is now a conflict to be solved.

…d-v3-seednode

� Conflicts:
�	core/src/main/resources/btc_mainnet.seednodes
@devinbileck devinbileck dismissed stale reviews from ripcurlx and wiz via 3b424fd June 26, 2020 10:47
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wiz As long as it's just one seednode restarting at the same time then it will get all the data delivered from the other seednodes. If two restart at the same time and request data from each other they might perhaps miss some data until they restart and request data from another seednode that has the missing data.

@sqrrm sqrrm merged commit 79f05bc into bisq-network:master Jul 1, 2020
@devinbileck devinbileck deleted the add-v3-seednode branch July 6, 2020 06:27
@ripcurlx ripcurlx added this to the v1.3.6 milestone Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants