Admin filter for auto-confirmation service addresses #4736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chimp1984
suggested changes
Nov 1, 2020
A service address can be filtered out using the admin key. This would be useful if a federated server failed, it could be filtered out so that the auto-confirmation operates with the remaining services. If all federated service addresses were filtered out the user would have to either confirm manually or use their own explorer service.
ripcurlx
approved these changes
Nov 2, 2020
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A service address can be filtered out using the admin key. This would be useful if a federated server failed, it could be filtered out so that the auto-confirmation operates with the remaining services. If all federated service addresses were filtered out the user would have to either confirm manually or use their own explorer service.
example:
Fixes #4683