-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substitute Unconfirmed for Processing BSQ swap #5884
Conversation
**Unconfirmed** BSQ swap seems like something failed. **Processing** is used by some wallets for unconfirmed transactions and has no negative implications.
Thanks for opening this pull request! |
@chimp1984 WDYT ☝️ |
Hm... I never saw processing being used in a BTC wallet and it comes with me with the wrong meaning that someone (company) is processing it. I think confirmed/unconfirmed is for Bitcoiners a standard term. But no super strong opinion either. |
"Pending" would not have third party implications and it's used at ETH/RSK wallets. |
I think if we keep the naming we might extend the
|
For ETH: Yes they depend usually heavily on 3rd parties (e.g. Infura), so "processing" in their context is more adequate IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - based on #5884 (comment)
Awesome work, congrats on your first merged pull request! |
Unconfirmed BSQ swap seems like something failed, while Processing is used by some wallets for unconfirmed transactions and has no negative implications.