Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute Unconfirmed for Processing BSQ swap #5884

Merged
merged 2 commits into from Dec 6, 2021

Conversation

MwithM
Copy link
Contributor

@MwithM MwithM commented Dec 1, 2021

Unconfirmed BSQ swap seems like something failed, while Processing is used by some wallets for unconfirmed transactions and has no negative implications.

Bildschirmfoto 2021-12-01 um 11 10 50
Bildschirmfoto 2021-12-01 um 11 10 58

**Unconfirmed** BSQ swap seems like something failed. **Processing** is used by some wallets for unconfirmed transactions and has no negative implications.
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 1, 2021

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 1, 2021

@chimp1984 WDYT ☝️

@chimp1984
Copy link
Contributor

Hm... I never saw processing being used in a BTC wallet and it comes with me with the wrong meaning that someone (company) is processing it. I think confirmed/unconfirmed is for Bitcoiners a standard term. But no super strong opinion either.

@MwithM
Copy link
Contributor Author

MwithM commented Dec 3, 2021

"Pending" would not have third party implications and it's used at ETH/RSK wallets.
Anyway, it's probably better to leave it as Unconfirmed because this is the specific, technical term and wait if it's really confusing once implemented. Probably we will get used to it.

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 3, 2021

I think if we keep the naming we might extend the Your BSQ swap trade is completed with:

Until your trade is included in a block you can see your completed trade at "Portfolio/Unconfirmed BSQ swaps"

@chimp1984
Copy link
Contributor

"Pending" would not have third party implications and it's used at ETH/RSK wallets.

For ETH: Yes they depend usually heavily on 3rd parties (e.g. Infura), so "processing" in their context is more adequate IMO.

Copy link
Contributor

@bisq-github-admin-3 bisq-github-admin-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - based on #5884 (comment)

@ripcurlx ripcurlx added this to the v1.8.0 milestone Dec 6, 2021
@ripcurlx ripcurlx merged commit e5c7071 into bisq-network:master Dec 6, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 6, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants