Bugfix: corrupted MaxTradePeriod when offer payment method changed #6176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripcurlx
approved these changes
Apr 28, 2022
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6174
maxTradeLimitandmaxTradePeriodwere not being set in theOfferPayloadwhen an offer was edited, instead they kept their values from the original offer. So, for example, changing a Zelle offer to CashByMail would result in the trade period being displayed wrong (4 days when it should be 8).As a side note, I cannot find any reason for these two fields being in the offer payload at all. Perhaps they are legacy and should be marked as deprecated? Most of the code seems to just pick them from the payment method, there only seems to be this one spot in TradeStepView that uses maxTradePeriod from the offer. ( -> fixed by e0c13df)