Remove dao disable toggle and cl options #6391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If set to true we do not fail validation in case there is no input text
…aMap. We cannot add new instance fields as that would break DAO consensus (hash for monitor). By using the extraMap there is no change in the DAO data. Not updated nodes simply ignore the usage of those data.
…r receiving the btc fees. Add isReducedIssuanceAmountToggle to let the contributor select if the reduced BSQ model is used or not.
`.run` directory can be used to share run configurations. Might be useful to check in and share some default configs. If so we need to remove that gitignore entry again. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Use first input instead of second from the compensation request tx for getting the receiver address. We cannot use a BTC input as we don't have the spending tx. For BSQ we have all transactions and can get the address from the spending output. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
…used Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
… due to existing static import 'bisq.desktop.util.FormBuilder.*' Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
There are a few 100 000 txOutputs and iterating them inside the iteration (about 700 issuances) took more than 20 seconds. Now we use a lookup map and it takes about 130 ms. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
…m.RECIPIENT_BTC_ADDRESS.getDefaultValue instead if there is no compensation request available. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements bisq-network/proposals#384
Base on #6386 starts at e927f13