Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in seednode. #6438

Merged
merged 1 commit into from Dec 5, 2022
Merged

Fix NPE in seednode. #6438

merged 1 commit into from Dec 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 5, 2022

Fix an NPE which was preventing proper startup.

Dec-04 13:23:31.519 [SeedNodeMain] INFO  b.n.p.p.PeerManager: Num of latestLivePeers=14 
Dec-04 13:23:41.563 [SeedNodeMain] INFO  b.n.p.p.PeerManager: We have 14 connections open. Our limit is 20 
Dec-04 13:25:11.363 [SeedNodeMain] INFO  b.n.p.p.PeerManager: We have 15 connections open. Our limit is 20 
Dec-04 13:25:21.963 [SeedNodeMain] INFO  b.n.p.p.g.RequestDataHandler: A timeout occurred at sending getDataRequest:PreliminaryGetDataRequest(supportedCapabilities=[0, 1, 2, 3, 4, 5, 6, 7, 9, 10, 11, 12, 13, 14, 15, 16, 17]) on nodeAddress:jmacx3kp7iku7eod6s4sasvxtdknakbsw2l2us5tyrk3q2634i222zid.onion:8000 
Dec-04 13:25:21.965 [SeedNodeMain] INFO  b.c.a.m.AppSetupWithP2P: onNoSeedNodeAvailable 
Dec-04 13:25:21.965 [SeedNodeMain] INFO  b.c.a.m.AppSetupWithP2P: onBasicServicesInitialized 
Dec-04 13:25:23.139 [SeedNodeMain] ERROR b.c.s.CommonSetup: Uncaught Exception from thread SeedNodeMain 
Dec-04 13:25:23.139 [SeedNodeMain] ERROR b.c.s.CommonSetup: throwableMessage= null 
Dec-04 13:25:23.139 [SeedNodeMain] ERROR b.c.s.CommonSetup: throwableClass= class java.lang.NullPointerException 
Dec-04 13:25:23.214 [SeedNodeMain] ERROR b.c.s.CommonSetup: Stack trace:
java.lang.NullPointerException
        at bisq.core.filter.FilterManager.onAllServicesInitialized(FilterManager.java:163)
        at bisq.core.app.misc.AppSetupWithP2P.onBasicServicesInitialized(AppSetupWithP2P.java:195)
        at bisq.core.app.misc.AppSetupWithP2PAndDAO.onBasicServicesInitialized(AppSetupWithP2PAndDAO.java:90)
        at bisq.core.app.misc.AppSetupWithP2P.lambda$startInitP2PNetwork$2(AppSetupWithP2P.java:104)
        at com.sun.javafx.binding.ExpressionHelper$SingleChange.fireValueChangedEvent(ExpressionHelper.java:181)
        at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
        at javafx.beans.property.BooleanPropertyBase.fireValueChangedEvent(BooleanPropertyBase.java:104)
        at javafx.beans.property.BooleanPropertyBase.markInvalid(BooleanPropertyBase.java:111)
        at javafx.beans.property.BooleanPropertyBase.set(BooleanPropertyBase.java:145)
        at bisq.core.app.misc.AppSetupWithP2P$2.onNoSeedNodeAvailable(AppSetupWithP2P.java:156)
        at java.base/java.util.concurrent.CopyOnWriteArrayList.forEach(CopyOnWriteArrayList.java:803)
        at java.base/java.util.concurrent.CopyOnWriteArraySet.forEach(CopyOnWriteArraySet.java:425)
        at bisq.network.p2p.P2PService.applyIsBootstrapped(P2PService.java:342)
        at bisq.network.p2p.P2PService.onNoSeedNodeAvailable(P2PService.java:318)
        at bisq.network.p2p.peers.getdata.RequestDataManager$2.onFault(RequestDataManager.java:388)
        at bisq.network.p2p.peers.getdata.RequestDataHandler.handleFault(RequestDataHandler.java:278)
        at bisq.network.p2p.peers.getdata.RequestDataHandler.lambda$requestData$0(RequestDataHandler.java:135)
        at bisq.common.FrameRateTimer.run(FrameRateTimer.java:50)
        at java.base/java.util.concurrent.CopyOnWriteArrayList.forEach(CopyOnWriteArrayList.java:803)
        at java.base/java.util.concurrent.CopyOnWriteArraySet.forEach(CopyOnWriteArraySet.java:425)
        at bisq.common.MasterTimer$1.lambda$run$0(MasterTimer.java:38)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:834)

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.9.7 milestone Dec 5, 2022
@ripcurlx ripcurlx merged commit c381006 into bisq-network:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant