Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Gradle Dependency Verification #6441

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Dec 6, 2022

The following artifacts failed verification:

  • javafx-base-16-linux.jar (org.openjfx:javafx-base:16) from repository MavenRepo
  • javafx-controls-16-linux.jar (org.openjfx:javafx-controls:16) from repository MavenRepo
  • javafx-fxml-16-linux.jar (org.openjfx:javafx-fxml:16) from repository MavenRepo
  • javafx-graphics-16-linux.jar (org.openjfx:javafx-graphics:16) from repository MavenRepo
  • protoc-3.19.1-linux-x86_64.exe (com.google.protobuf:protoc:3.19.1) from repository MavenRepo
  • protoc-gen-grpc-java-1.42.1-linux-x86_64.exe (io.grpc:protoc-gen-grpc-java:1.42.1) from repository MavenRepo
  • jackson-base-2.12.1.pom
  • protoc-3.19.1-windows-x86_64.exe
  • protoc-gen-grpc-java-1.42.1-windows-x86_64.exe
  • junit-bom-5.7.0.pom
  • javafx-base-16-win.jar
  • javafx-controls-16-win.jar
  • javafx-fxml-16-win.jar
  • javafx-graphics-16-win.jar

@alvasw
Copy link
Contributor Author

alvasw commented Dec 6, 2022

The following error messages should disappear when you build Bisq.

Project :desktop => no module-info.java found
Dependency verification failed for configuration ':desktop:runtimeClasspath'
4 artifacts failed verification:
  - javafx-base-16-linux.jar (org.openjfx:javafx-base:16) from repository MavenRepo
  - javafx-controls-16-linux.jar (org.openjfx:javafx-controls:16) from repository MavenRepo
  - javafx-fxml-16-linux.jar (org.openjfx:javafx-fxml:16) from repository MavenRepo
  - javafx-graphics-16-linux.jar (org.openjfx:javafx-graphics:16) from repository MavenRepo
If the artifacts are trustworthy, you will need to update the gradle/verification-metadata.xml file by following the instructions at https://docs.gradle.org/7.3.3/userguide/dependency_verification.html#sec:troubleshooting-verification

Open this report for more details: file:///home/user/Documents/legacy-bisq/build/reports/dependency-verification/at-1670343404097/dependency-verification-report.html

> Task :proto:extractIncludeProto UP-TO-DATE
> Task :proto:extractProto UP-TO-DATE

> Task :proto:generateProto UP-TO-DATE
Dependency verification failed for configuration ':proto:protobufToolsLocator_protoc'
5 artifacts failed verification:
  - javafx-base-16-linux.jar (org.openjfx:javafx-base:16) from repository MavenRepo
  - javafx-controls-16-linux.jar (org.openjfx:javafx-controls:16) from repository MavenRepo
  - javafx-fxml-16-linux.jar (org.openjfx:javafx-fxml:16) from repository MavenRepo
  - javafx-graphics-16-linux.jar (org.openjfx:javafx-graphics:16) from repository MavenRepo
  - protoc-3.19.1-linux-x86_64.exe (com.google.protobuf:protoc:3.19.1) from repository MavenRepo
If the artifacts are trustworthy, you will need to update the gradle/verification-metadata.xml file by following the instructions at https://docs.gradle.org/7.3.3/userguide/dependency_verification.html#sec:troubleshooting-verification

Open this report for more details: file:///home/user/Documents/legacy-bisq/build/reports/dependency-verification/at-1670343404097/dependency-verification-report.html
Dependency verification failed for configuration ':proto:protobufToolsLocator_grpc'
6 artifacts failed verification:
  - javafx-base-16-linux.jar (org.openjfx:javafx-base:16) from repository MavenRepo
  - javafx-controls-16-linux.jar (org.openjfx:javafx-controls:16) from repository MavenRepo
  - javafx-fxml-16-linux.jar (org.openjfx:javafx-fxml:16) from repository MavenRepo
  - javafx-graphics-16-linux.jar (org.openjfx:javafx-graphics:16) from repository MavenRepo
  - protoc-3.19.1-linux-x86_64.exe (com.google.protobuf:protoc:3.19.1) from repository MavenRepo
  - protoc-gen-grpc-java-1.42.1-linux-x86_64.exe (io.grpc:protoc-gen-grpc-java:1.42.1) from repository MavenRepo
If the artifacts are trustworthy, you will need to update the gradle/verification-metadata.xml file by following the instructions at https://docs.gradle.org/7.3.3/userguide/dependency_verification.html#sec:troubleshooting-verification

Open this report for more details: file:///home/user/Documents/legacy-bisq/build/reports/dependency-verification/at-1670343404097/dependency-verification-report.html

> Task :proto:compileJava

@alvasw alvasw marked this pull request as draft December 6, 2022 16:39
The following artifacts failed verification:
  - javafx-base-16-linux.jar (org.openjfx:javafx-base:16) from repository MavenRepo
  - javafx-controls-16-linux.jar (org.openjfx:javafx-controls:16) from repository MavenRepo
  - javafx-fxml-16-linux.jar (org.openjfx:javafx-fxml:16) from repository MavenRepo
  - javafx-graphics-16-linux.jar (org.openjfx:javafx-graphics:16) from repository MavenRepo
  - protoc-3.19.1-linux-x86_64.exe (com.google.protobuf:protoc:3.19.1) from repository MavenRepo
  - protoc-gen-grpc-java-1.42.1-linux-x86_64.exe (io.grpc:protoc-gen-grpc-java:1.42.1) from repository MavenRepo
  - jackson-base-2.12.1.pom
  - protoc-3.19.1-windows-x86_64.exe
  - protoc-gen-grpc-java-1.42.1-windows-x86_64.exe
  - junit-bom-5.7.0.pom
  - javafx-base-16-win.jar
  - javafx-controls-16-win.jar
  - javafx-fxml-16-win.jar
  - javafx-graphics-16-win.jar
@alvasw alvasw force-pushed the fix_gradle_dependency_verification branch from bf24ce3 to 90070c8 Compare December 6, 2022 18:35
@alvasw alvasw marked this pull request as ready for review December 6, 2022 19:07
Copy link
Collaborator

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.7 milestone Dec 6, 2022
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 3deda88 into bisq-network:master Dec 6, 2022
@alvasw alvasw deleted the fix_gradle_dependency_verification branch January 1, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants